Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

upgrades dependencies #892

Merged
merged 3 commits into from
Oct 31, 2023
Merged

upgrades dependencies #892

merged 3 commits into from
Oct 31, 2023

Conversation

bockstaller
Copy link
Contributor

Upgrades all dependencies to the newest state that doesn't require large changes.

The largest change is the removal of await client.onReady(); caused by https://github.com/microsoft/vscode-languageserver-node/blob/main/README.md#3170-protocol-800-json-rpc-800-client-and-800-server

After this PR, we could move to eslint (and prettier?) as tslint is deprecated.

@chadlwilson
Copy link
Contributor

chadlwilson commented Oct 30, 2023

You’ll need to rebase off master as I fixed the build the other day (in #886) to ensure a minimalist change was made that had all the functional tests passing before anything further was done.

@chadlwilson chadlwilson marked this pull request as draft October 30, 2023 14:13
Signed-off-by: Lukas Bockstaller <lukas.bockstaller@posteo.de>
@bockstaller
Copy link
Contributor Author

@chadlwilson done

@bockstaller bockstaller marked this pull request as ready for review October 30, 2023 14:18
@chadlwilson chadlwilson added dependencies Pull requests that update a dependency file javascript Pull requests that update Javascript code labels Oct 30, 2023
@chadlwilson
Copy link
Contributor

Thanks for this! I did briefly try the vscode dep updates but didn't look any deeper as to why it wasn't working :-D

Have you given it a test drive "in the real world"? :-)

@bockstaller
Copy link
Contributor Author

Yep, I am running it locally and I've seen no anomalies so far

package.json Outdated Show resolved Hide resolved
package.json Outdated Show resolved Hide resolved
package.json Outdated Show resolved Hide resolved
Signed-off-by: Lukas Bockstaller <lukas.bockstaller@posteo.de>
@zabil zabil merged commit 0c88370 into getgauge:master Oct 31, 2023
4 checks passed
@bockstaller bockstaller deleted the version-upgrades branch October 31, 2023 13:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file javascript Pull requests that update Javascript code
Development

Successfully merging this pull request may close these issues.

3 participants